[Rpm-maint] [rpm-software-management/rpm] Take changelog timezone in account (RhBug 1715412) (#739)

Panu Matilainen notifications at github.com
Mon Jun 17 10:08:30 UTC 2019

pmatilai commented on this pull request.

> @@ -44,7 +44,8 @@ static int dateToTimet(const char * datestr, time_t * secs, int * date_words)
     struct tm time, ntime;
     const char * const * idx;
     char *p, *pe, *q, *date, *tz;
-    char tz_name[10];               /* name of timezone (if extended format is used) */
+    char *tz_name = NULL;               /* TZ database name (if extended format is used) */

Similar to my other database complaints, the comment change seems quite questionable. 
It's not a name of the database as the comment now indicates, but the name of the timezone. No comment change is necessary, and in fact this never really needed that comment to begin with because the variable name says it all. And that we're wasting time discussing something like this is a fine example of superfluous comments being bad.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190617/c41bd72a/attachment-0001.html>

More information about the Rpm-maint mailing list