[Rpm-maint] [rpm-software-management/rpm] RFE: %generate_buildrequires should re-run until all dependencies are satisfied (#755)

[Miro Hrončok]

%generate_buildrequires currently only runs once. it should loop until no new depndencies are needed.

To reproduce:

```
%generate_buildrequires
echo package1
if rpm -q package1 &>/dev/null; then echo package2; fi
```

Actual result:

```
Executing(%generate_buildrequires):
+ umask 022
+ cd /builddir/build/BUILD
+ echo package1
+ rpm -q package1
+ RPM_EC=0
BUILDSTDERR: ++ jobs -p
+ exit 0
package1
Wrote: /builddir/build/SRPMS/reproducer_dynbrs-0.0-1.fc31.buildreqs.nosrc.rpm
Child return code was: 11

(installs package1)

Executing(%generate_buildrequires):
+ umask 022
+ cd /builddir/build/BUILD
+ echo package1
+ rpm -q package1
+ echo package2
+ RPM_EC=0
BUILDSTDERR: ++ jobs -p
+ exit 0
package1
package2
Executing(%build):
...
```


Expected results:

```
Executing(%generate_buildrequires):
+ umask 022
+ cd /builddir/build/BUILD
+ echo package1
+ rpm -q package1
+ RPM_EC=0
BUILDSTDERR: ++ jobs -p
+ exit 0
package1
Wrote: /builddir/build/SRPMS/reproducer_dynbrs-0.0-1.fc31.buildreqs.nosrc.rpm
Child return code was: 11

(installs package1)

Executing(%generate_buildrequires):
+ umask 022
+ cd /builddir/build/BUILD
+ echo package1
+ rpm -q package1
+ echo package2
+ RPM_EC=0
BUILDSTDERR: ++ jobs -p
+ exit 0
package1
package2
Wrote: /builddir/build/SRPMS/reproducer_dynbrs-0.0-1.fc31.buildreqs.nosrc.rpm
Child return code was: 11

(installs package2)

Executing(%generate_buildrequires):
+ umask 022
+ cd /builddir/build/BUILD
+ echo package1
+ rpm -q package1
+ echo package2
+ RPM_EC=0
BUILDSTDERR: ++ jobs -p
+ exit 0
package1
package2
Executing(%build):
...
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/755
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190619/09b8b757/attachment-0001.html>