[Rpm-maint] [rpm-software-management/rpm] Support triple operator for conditional shortcut (#115) (#746)

Panu Matilainen notifications at github.com
Thu Jun 20 10:06:00 UTC 2019


pmatilai commented on this pull request.



> +    SKIPBLANK(parts->g, c);
+
+    /* after %{? {macroo} must be ':' */
+    if (parts->g[0] == ':') {
+	parts->g++;
+	SKIPBLANK(parts->g,c);
+	parts->ge = parts->g;
+	while ((parts->ge[0] != 0) && (parts->ge[0] != ':')) {
+	    parts->ge++;
+	    if (parts->ge[0] == '{') {
+		if ((parts->ge = matchchar(parts->ge++, '{', '}')) == NULL)
+		    return NULL;
+	    }
+	}
+    } else {
+	return NULL;

Arrange a single point of return to the function, goto exit or such.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/746#pullrequestreview-252200124
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190620/37282490/attachment.html>


More information about the Rpm-maint mailing list