[Rpm-maint] [rpm-software-management/rpm] Support triple operator for conditional shortcut (#115) (#746)

Panu Matilainen notifications at github.com
Thu Jun 20 10:13:59 UTC 2019

pmatilai commented on this pull request.

>  	str++;
     return str;
+static void partsInit(macroPartition *parts)
+    parts->f = parts->fe = NULL;
+    parts->g = parts->ge = NULL;
+    parts->h = parts->he = NULL;
+    parts->fn = parts->gn = parts->hn = 0;
+    return;

In general, never initialize more than one variable on a line, it only makes it harder to read. In a case like this, just memset() to zero.

The return at end of void function is redundant.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190620/c1e0457b/attachment-0001.html>

More information about the Rpm-maint mailing list