[Rpm-maint] [rpm-software-management/rpm] Take changelog timezone in account (RhBug 1715412) (#739)

Panu Matilainen notifications at github.com
Mon Jun 24 10:00:56 UTC 2019


pmatilai commented on this pull request.



> @@ -44,7 +44,8 @@ static int dateToTimet(const char * datestr, time_t * secs, int * date_words)
     struct tm time, ntime;
     const char * const * idx;
     char *p, *pe, *q, *date, *tz;
-    char tz_name[10];               /* name of timezone (if extended format is used) */
+    char *tz_name = NULL;               /* TZ database name (if extended format is used) */

Yes I can see it's used as a column name in that list, as a shorthard for "name *in* timezone database". But "foo database name" generally refers to the name of the database itself, not a value in it. If I were talking about "rpm database name", you wouldn't think of individual package names would you? 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/739#discussion_r296645445
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190624/8581bcd8/attachment-0001.html>


More information about the Rpm-maint mailing list