[Rpm-maint] [rpm-software-management/rpm] Take changelog timezone in account (RhBug 1715412) (#739)

Panu Matilainen notifications at github.com
Mon Jun 24 10:44:45 UTC 2019

pmatilai commented on this pull request.

> @@ -44,7 +44,8 @@ static int dateToTimet(const char * datestr, time_t * secs, int * date_words)
     struct tm time, ntime;
     const char * const * idx;
     char *p, *pe, *q, *date, *tz;
-    char tz_name[10];               /* name of timezone (if extended format is used) */
+    char *tz_name = NULL;               /* TZ database name (if extended format is used) */

Oh and BTW this line overflows to a second line for no good reason at all. Lines should be kept under 80 characters when at all possible. The new error message line, and also the older "first part of year..." comment break this rule, for no good reasons.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190624/7fd5f77d/attachment.html>

More information about the Rpm-maint mailing list