[Rpm-maint] [rpm-software-management/rpm] Take changelog timezone in account (RhBug 1715412) (#739)

Panu Matilainen notifications at github.com
Mon Jun 24 11:08:36 UTC 2019

pmatilai commented on this pull request.

> @@ -44,7 +44,8 @@ static int dateToTimet(const char * datestr, time_t * secs, int * date_words)
     struct tm time, ntime;
     const char * const * idx;
     char *p, *pe, *q, *date, *tz;
-    char tz_name[10];               /* name of timezone (if extended format is used) */
+    char *tz_name = NULL;               /* TZ database name (if extended format is used) */

Also, *this* string is just something in the spec. We don't know if its anything resembling a valid timezone name, it's just what we *expect* it to be. And certainly it doesn't come from any database. So this turns what was originally a superfluous but harmless comment into a misleading one. If you feel compelled to change it, then just *remove* the comment please because it serves absolutely no purpose. 

What would deserve a comment however is consulting the "magic" tzname variable.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190624/16bc48c1/attachment.html>

More information about the Rpm-maint mailing list