[Rpm-maint] [rpm-software-management/rpm] Watch out for char signedness when checking for printable (#771)

Panu Matilainen notifications at github.com
Wed Jun 26 14:02:18 UTC 2019


Commit ee3126dd3d4ca609f254ac5d647c9ff3e413e9dd added an innocent
looking check to ban characters below < 0x20, but char is signed
so it ends up banning the whole upper range too. Cast to unsigned
and add a comment as a reminder. Thanks to Michael Schroeder for
pointing this out!

Fixes ee3126dd3d4ca609f254ac5d647c9ff3e413e9dd
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/771

-- Commit Summary --

  * Watch out for char signedness when checking for printable

-- File Changes --

    M build/files.c (3)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/771.patch
https://github.com/rpm-software-management/rpm/pull/771.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/771
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190626/9b2c759e/attachment.html>


More information about the Rpm-maint mailing list