[Rpm-maint] [rpm-software-management/rpm] validFilename: Use iscntrl from ctype.h (#773)

[Panu Matilainen]

Dunno, but I dont think the "locale specific" is there just for fun. See eg https://www.gnu.org/software/gnulib/manual/html_node/iscntrl.html:

> Note: This function’s behaviour depends on the locale, but does not support the multibyte characters that occur in strings in locales with MB_CUR_MAX > 1 (this includes all the common UTF-8 locales). 

...and 

> c_iscntrl
>
>   This function operates in a locale independent way and returns true only for ASCII characters. It is provided by the Gnulib module ‘c-ctype’.
> 


...which is the behavior rpm wants. There are in fact several similar risfoo() variants in rpmstring.h that are locale independent, for similar reasons.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/773#issuecomment-506695119
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190628/cad43872/attachment.html>