[Rpm-maint] [rpm-software-management/rpm] Add %__autoreconf macro (#688)

Tomasz Kłoczko notifications at github.com
Thu May 2 09:08:00 UTC 2019


Majority of the most Linux distributions still uses auto tools and it will be like this for next couple of years.
If someone want to use for example -Wl,--as-needed or LTO transparently all what is needed to prepare all those projects is call autoreconf before configure execution.
If it is necessary to use aclocal, autoconf, libtoolize or automake usually it is clear sign that auto suite is not finished or it is wrongly implemented.
Just checked my own stash of already cleaned packages and:
<pre>[tkloczko at domek SPECS.g2v]$ grep ^autoreconf *| wc -l
300
[tkloczko at domek SPECS.g2v]$ grep "^%meson " *| wc -l
105
[tkloczko at domek SPECS.g2v]$ grep "^%cmake " *| wc -l
21
[tkloczko at domek SPECS.g2v]$ ls -1 | wc -l
489
</pre>
Yesterday in my own set of macros I've changed %__{aclocal,automake,autoconf,libtool,autoreconf} macros to be listed with full path.
Would you accept as well that kind of patch as well?
Effectively such change reduces number of syscalls by few during whole build process but provide all those macros with full path is important from security point of view as most of the distributions has /usr/local/bin on the front of the $PATH. In other words with full paths it is not possible to alter build process by putting copies of the auto tools in /usr/local/bin.
I'm still reviewing all other macros to apply similar changes to mask in macros pull paths to all used during build process commands. Those masking is as well important for me as I've started building Solaris (not rpm but IPS one) packages using rpm spec files. In other words this macros masking allows reuse almost 100% of the Linux build procedure on Solaris as well.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/688#issuecomment-488600351
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190502/d57655a8/attachment-0001.html>


More information about the Rpm-maint mailing list