[Rpm-maint] [rpm-software-management/rpm] Dynamic Build Dependencies (#593)

Panu Matilainen notifications at github.com
Mon May 6 13:42:51 UTC 2019


pmatilai commented on this pull request.



> @@ -172,9 +174,113 @@ rpmRC doScript(rpmSpec spec, rpmBuildFlags what, const char *name,
     return rc;
 }
 
-static rpmRC buildSpec(BTA_t buildArgs, rpmSpec spec, int what)
+static rpmRC doBuildRequires(rpmSpec spec, int test) {

In case of functions, the opening curly brace belongs to a line of its own. This is a recurring theme, please check and fix all newly introduced functions.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/593#pullrequestreview-233985799
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190506/7b881f88/attachment.html>


More information about the Rpm-maint mailing list