[Rpm-maint] [rpm-software-management/rpm] Fix memory reading in the expansion of an unfinished macro "{%!" (#694)

[Panu Matilainen]

The code seems fine, and :+1: for taking the opportunity to refactor. The commit message just needs a bit of love.

This is a software, not hardware issue. You're fixing a buffer over-read, or invalid memory access, not memory reading :slightly_smiling_face: (commit 54f24ec summary is equally bad)

The word is "refactor", not reflector. And "interrogation point", not mark, but more widely known as a "question mark". And the reproducer is always good to state explicitly where possible, plus the other conditions. Referring to a similar commit doesn't really tell me whether this was also found by memory sanitizer or if this is something that occurs in the wild or...


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/694#issuecomment-490778061
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190509/390155e0/attachment.html>