[Rpm-maint] [rpm-software-management/rpm] Dynamic Build Dependencies (#593)

Panu Matilainen notifications at github.com
Fri May 10 06:43:05 UTC 2019


pmatilai commented on this pull request.



> @@ -47,7 +47,7 @@ static rpmRC doRmSource(rpmSpec spec)
  * @todo Single use by %%doc in files.c prevents static.
  */
 rpmRC doScript(rpmSpec spec, rpmBuildFlags what, const char *name,
-		const char *sb, int test)
+	       const char *sb, StringBuf * sb_stdoutp, int test)

Return value arguments should generally be the last. We failed to adjust rpmfcExec() accordingly but perhaps we could still fix this one...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/593#pullrequestreview-235946561
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190509/d7a990ed/attachment.html>


More information about the Rpm-maint mailing list