[Rpm-maint] [rpm-software-management/rpm] Dynamic Build Dependencies (#593)

Panu Matilainen notifications at github.com
Fri May 10 06:52:37 UTC 2019


pmatilai commented on this pull request.



> @@ -172,6 +172,7 @@ rpmRC doScript(rpmSpec spec, rpmBuildFlags what, const char *name,
     return rc;
 }
 
+

Stray newline added.

Like said in an earlier comment, the addition of rpmtsFromPyObject() could be merged with this commit because it doesn't make much sense alone, especially without any rationale in the commit message. And here too: explain why this is added in the message.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/593#pullrequestreview-235949222
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190509/5f9a5679/attachment.html>


More information about the Rpm-maint mailing list