[Rpm-maint] [rpm-software-management/rpm] Only calculate buildhost and buildtime during an actual build (#935)

Panu Matilainen notifications at github.com
Mon Nov 11 10:34:08 UTC 2019

Commit fa303d5ba6bef5b4a44b884c6dadadc27b594caa moved buildhost and
buildtime calculation out of the package generation to early spec
initialization, but this broke reproducable builds: if buildtime is
to be set from changelog, changelog needs to be parsed first.

So either we need to do it twice or we need to do it right, and
besides avoiding duplication, conceptually these values are only
meaningful during a build and not a parse, so this restores that part
of the original code while keeping things thread-safe.

Fixes: #932
You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * Only calculate buildhost and buildtime during an actual build

-- File Changes --

    M build/build.c (49)
    M build/spec.c (50)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20191111/428eacb9/attachment.html>

More information about the Rpm-maint mailing list