[Rpm-maint] [rpm-software-management/rpm] Stop blocking when GPG process dies prematurely (RhBug:1746353) (#938)

[Panu Matilainen]

pmatilai commented on this pull request.



> @@ -276,7 +282,26 @@ static int runGPG(sigTarget sigt, const char *sigfile)
     rpmPopMacro(NULL, "__plaintext_filename");
     rpmPopMacro(NULL, "__signature_filename");
 
+    /* The child GPG process may terminate without ever opening the pipe (such
+     * as when the key is expired), causing our parent process to get forever
+     * stuck on the Fopen() call below (see fifo(7) for details).  To fix that,
+     * we need to let the underlying open(2) unblock when SIGCHLD is received,
+     * by registering a no-op handler, so here we go: */

On another purely stylistic note, this comment is on the verbose side. Some general guidelines on the topic:
- use comments sparingly, subtle and non-obvious things (this certainly classifies)
- try to stick to one-liners for in-line comments, unless it's something *really* special
- the preferred place for comments is at head of functions, and longer comments are okay there
- ...but story-telling belongs to commit messages (where OTOH this sort of background info is golden)

The kernel coding style differs in various aspects and some things just don't apply, but in general it's usually excellent advice and on comments it's totally spot-on in rpm too:
https://www.kernel.org/doc/html/v4.10/process/coding-style.html#commenting

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/938#pullrequestreview-318168130
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20191118/25de65ae/attachment-0001.html>