[Rpm-maint] [rpm-software-management/rpm] Stop blocking when GPG process dies prematurely (RhBug:1746353) (#938)

[Michal Domonkos]

> Regarding opening the pipe for reading: oh yeah, that's right. You can't do it before the fork. But it should work if you do it after the fork.

Actually it does not! :) I tried opening it after the fork (in the RPM process), just before the writer end is opened:

```
Fopen(namedPipeName, "r");  // here
fnamedPipe = Fopen(namedPipeName, "w");
```

And it just blocks on the first Fopen. Or am I missing something?

> It would be much saner if the gpg call would just read from stdin, i.e. if we use a normal pipe instead of that named pipe. But it's a bit late to change that and I guess /dev/stdin does not exist in every system rpm supports.

Yeah, probably. But like you said, rewriting it would probably be too risky at this point, with little added benefit.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/938#issuecomment-555482392
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20191119/4ffaafed/attachment.html>