[Rpm-maint] [rpm-software-management/rpm] Stop blocking when GPG process dies prematurely (RhBug:1746353) (#938)

Panu Matilainen notifications at github.com
Wed Nov 27 11:40:38 UTC 2019


pmatilai commented on this pull request.



> @@ -276,7 +296,17 @@ static int runGPG(sigTarget sigt, const char *sigfile)
     rpmPopMacro(NULL, "__plaintext_filename");
     rpmPopMacro(NULL, "__signature_filename");
 
-    fnamedPipe = Fopen(namedPipeName, "w");
+    while (1) {

Looping while fnamedPipe remains NULL might be a more natural check here, eternal loops always make me a bit fidgety.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/938#pullrequestreview-323611419
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20191127/070a356f/attachment.html>


More information about the Rpm-maint mailing list