[Rpm-maint] [rpm-software-management/rpm] rpmbuild: %patch: fix a memory leak (#873)

Peter Jones notifications at github.com
Wed Oct 2 16:30:54 UTC 2019


Yeah, I noticed that it still leaks on multiple uses, and there may be better solutions these days.  I chose to stop here for an entirely selfish reason - using -b twice is clearly wrong to do, with only invoking it once, that leak is chaff that shows up when I'm running valgrind to check my own patches for safety errors.

There's another piece of chaff that shows up as well, but it's the GOMP TLS initialization, so it should be handled in a valgrind suppression that's not specific to rpm. Aside from those, the codepaths I've been hacking near don't have anything show up in valgrind, so removing this one makes checking my code changes much easier.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/873#issuecomment-537574552
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20191002/567d40a8/attachment.html>


More information about the Rpm-maint mailing list