[Rpm-maint] [rpm-software-management/rpm] [RFC] Make "%patchlist -f patches" work. (#874)
Panu Matilainen
notifications at github.com
Fri Oct 4 12:06:32 UTC 2019
Nothing against adding -f support, but this adds third variant of essentially the same code that is in readFilesManifest() and addFileToTag(), with its own pecularities (at least missing %__file_name macro handling), when we're trying instead to eliminate these redundancies across the board.
I'd also rather see the file contents appended to the same array that parseLines() originally produces to have just one place where addSource() is called for this, similarly to what readFilesManifest() does. The file reading logic from readFilesManifest() could probably be fairly easily be split into a separate helper shared between all these variants (similar to parseLines()), but I do understand if you're not interested in such a refactor job.
I also wonder if it's ever sane to have an empty patches/source file. In case of %files it's permitted mostly due to historical reasons IIRC, but this is probably different.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/874#issuecomment-538369709
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20191004/454b9684/attachment.html>
More information about the Rpm-maint
mailing list