[Rpm-maint] [rpm-software-management/rpm] Make %{buildsubdir} usable without being a side effect of %setup. (#860)

Panu Matilainen notifications at github.com
Wed Oct 9 08:24:53 UTC 2019


pmatilai commented on this pull request.



>      }
     /* Mer addition - support --build-in-place */
     if (rpmExpandNumeric("%{_build_in_place}")) {
 	buildInPlace = 1;
-	spec->buildSubdir = NULL;
+	rpmPushMacro(spec->macros, "buildsubdir", NULL, "", RMIL_SPEC);

This would have to be rpmPopMacro(), as all those %{?buildsubdir} conditionals only test whether the macro is defined at all, not whether it's empty.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/860#pullrequestreview-299243861
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20191009/ecabfd62/attachment.html>


More information about the Rpm-maint mailing list