[Rpm-maint] [rpm-software-management/rpm] Make %{buildsubdir} usable without being a side effect of %setup. (#860)
Panu Matilainen
notifications at github.com
Wed Oct 9 08:31:31 UTC 2019
pmatilai commented on this pull request.
> @@ -345,7 +349,7 @@ static int doSetupMacro(rpmSpec spec, const char *line)
}
if (!createDir) {
- rasprintf(&buf, "cd '%s'", spec->buildSubdir);
+ buf = rpmExpand("%{?buildsubdir:cd '%{buildsubdir}'}", NULL);
We didn't need all these conditionals before, why do we need them now?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/860#pullrequestreview-299247606
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20191009/762271ea/attachment.html>
More information about the Rpm-maint
mailing list