[Rpm-maint] [rpm-software-management/rpm] Make %{buildsubdir} usable without being a side effect of %setup. (#860)

Panu Matilainen notifications at github.com
Wed Oct 9 08:37:23 UTC 2019


pmatilai commented on this pull request.



> @@ -345,7 +349,7 @@ static int doSetupMacro(rpmSpec spec, const char *line)
     }
 
     if (!createDir) {
-	rasprintf(&buf, "cd '%s'", spec->buildSubdir);
+	buf = rpmExpand("%{?buildsubdir:cd '%{buildsubdir}'}", NULL);

As an aside, the build-in-place logic seems a bit broken to begin with: it pushes macro will NULL body, which isn't the right thing, it shouldn't define buildsubdir at all then (but that's not the fault of this patchset of course)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/860#discussion_r332891423
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20191009/917e2f88/attachment.html>


More information about the Rpm-maint mailing list