[Rpm-maint] [rpm-software-management/rpm] Make %{buildsubdir} usable without being a side effect of %setup. (#860)

Panu Matilainen notifications at github.com
Wed Oct 9 10:35:55 UTC 2019


I've been mulling over this thing over and over: in principle, I like the idea of eliminating magic from %setup a lot, I've just been worried that there are cases that our test-suite doesn't exhibit that rely on some subtleties around spec->buildSubdir being untouchable by macros (maybe because I remember spec->buildRoot being ridiculously tricky for what it is to get right). 

So I dug around a bit, and the short version is that spec->buildSubdir just goes back a long, long, LONG time, back to times where macros were barely supported to begin with and eg macro conditionals didn't exist at all (commit 757e50ffc827297e36f793cf79ddc471878f6d0b if you're interested in archeology). Since then, there aren't many related changes except for commit c1afde7db586b58ad8e1ccf8d3825130f3babf14 which moves one place towards this direction.

At least I fail to see any hidden magic that would prevent us from going all macros with buildsubdir. There's a slight loss of control in theory, but then specs overriding macros can screw rpm over in so many ways anyway that its hardly relevant in reality. And on the plus side, it's one hidden piece of magic less, and one step closer to being able to implement %setup as an actual macro.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/860#issuecomment-539943640
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20191009/a7620c1d/attachment.html>


More information about the Rpm-maint mailing list