[Rpm-maint] [rpm-software-management/rpm] Improve "git am" support. (#854)

Panu Matilainen notifications at github.com
Wed Oct 9 10:53:31 UTC 2019


pmatilai commented on this pull request.



> +%_default_apply_flags %{expand:%%{?_default_%{__scm}_apply_flags}}
+
+# Choose between default apply flags and user-defined apply flags
+%_apply_flags %{expand:%%{!?__scm_%{__scm}_apply_flags:%%{?_default_apply_flags}}%%{?__scm_%{__scm}_apply_flags:%%{?__scm_%{__scm}_apply_flags}}}
+
+# Build the scm-indepdendent default import flags
+%_default_import_flags %{expand:%%{?_default_%{__scm}_import_flags}}
+
+# Choose between default import flags and user-defined import flags
+%_import_flags %{expand:%%{!?__scm_%{__scm}_import_flags:%%{?_default_import_flags}}%%{?__scm_%{__scm}_import_flags:%%{?__scm_%{__scm}_import_flags}}}
+
+# Build the scm-independant default commit flags
+%_default_commit_flags %{expand:%%{?_default_%{__scm}_commit_flags}}
+
+# Choose between default commit flags and user-defined commit flags
+%_commit_flags %{expand:%%{!?__scm_%{__scm}_commit_flags:%%{?_default_commit_flags}}%%{?__scm_%{__scm}_commit_flags:%%{?__scm_%{__scm}_commit_flags}}}

%_apply_flags, %_import_flags and %_commit flags are awfully generic names. Please prepend "scm" or such in there someplace, eg %_scm_apply_flags (but I didn't verify whether that clashes with something)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/854#pullrequestreview-299325762
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20191009/81866b0b/attachment-0001.html>


More information about the Rpm-maint mailing list