[Rpm-maint] [rpm-software-management/rpm] Avoid using types from Lua includes in rpmlua.h again (#893)

Panu Matilainen notifications at github.com
Thu Oct 10 11:16:38 UTC 2019


rpmlua.h was originally written in a way that allows it to be included
regardless of whether Lua is actually enabled in rpm or not, or where
Lua headers are, specifically to isolate the rest of rpm from these
details. That was changed in commit 62bd62286aa888c60145daf315a938dd87eadc89
when <lauxlib.h> started getting included in rpmlua.h, which leaks to
places like librpmbuild which do not directly use Lua.

The way Lua typedef's the luaL_Reg struct to itself defies my C fu for
for handling this in some nicer typesafe way, fix this all by just using
a void pointer instead, this is just an internal API where buyer can be
expected to beware.

Fixes #888
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/893

-- Commit Summary --

  * Avoid using types from Lua includes in rpmlua.h again

-- File Changes --

    M lib/rpmliblua.c (1)
    M rpmio/rpmlua.c (3)
    M rpmio/rpmlua.h (8)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/893.patch
https://github.com/rpm-software-management/rpm/pull/893.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/893
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20191010/b741c825/attachment-0001.html>


More information about the Rpm-maint mailing list