[Rpm-maint] [rpm-software-management/rpm] Multiple ndb improvements (#895)

Panu Matilainen notifications at github.com
Tue Oct 15 10:33:09 UTC 2019


pmatilai commented on this pull request.



> @@ -228,16 +265,10 @@ static int rpmxdbReadHeader(rpmxdb xdb)
     if (!slotnpages || !pagesize || stb.st_size % pagesize != 0)
 	return RPMRC_FAIL;
     xdb->pagesize = pagesize;
+    xdb->mapflags = xdb->rdonly ? PROT_READ : PROT_READ | PROT_WRITE, MAP_SHARED;

This generates a warning:
```
backend/ndb/rpmxdb.c: In function ‘rpmxdbReadHeader’:
backend/ndb/rpmxdb.c:268:69: warning: right-hand operand of comma expression has no effect [-Wunused-value]
  268 |     xdb->mapflags = xdb->rdonly ? PROT_READ : PROT_READ | PROT_WRITE, MAP_SHARED;
      |    
```

I assume the ',' is supposed to be a '|' instead :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/895#pullrequestreview-301807253
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20191015/d07faed7/attachment.html>


More information about the Rpm-maint mailing list