[Rpm-maint] [rpm-software-management/rpm] Eliminate uses of non-threadsafe locatime() and ctime() functions (#921)

Panu Matilainen notifications at github.com
Thu Oct 31 10:37:27 UTC 2019


LGTM pointed out localtime() and ctime() are not thread-safe, and additionally ctime() is considered obsolete since POSIX.1-2008. Replace with localtime_r() and strftime() instead. 

Long broken --prtpkts debug switch is fixed in a separate commit to have means of testing the strftime() change.
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/921

-- Commit Summary --

  * Resurrect --prtpkts debug switch functionality
  * Replace uses of localtime() with the re-entrant variant
  * Replace use of obsolete ctime() with strftime()

-- File Changes --

    M configure.ac (2)
    M lib/formats.c (6)
    M lib/query.c (4)
    M lib/rpmchecksig.c (2)
    M rpmio/rpmkeyring.c (6)
    M rpmio/rpmpgp.c (5)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/921.patch
https://github.com/rpm-software-management/rpm/pull/921.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/921
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20191031/a94286d9/attachment.html>


More information about the Rpm-maint mailing list