[Rpm-maint] [rpm-software-management/rpm] Cannot leave comments after %endif (#829)

Merlin Mathesius notifications at github.com
Fri Sep 6 18:04:53 UTC 2019


I'd really like to see this addressed.

I recently started getting such warnings from a package spec I maintain. It has several levels of nested `%if`s and cases where the `%if` and corresponding `%else`/`%endif` are separated by many lines. It's really helpful to be able to match up the conditionals with a simple connected comment. Even the C source code for the spec parser that is reporting this warning makes use of a [comment on an `#endif` line](https://github.com/rpm-software-management/rpm/blob/0488fdc927e6d31a0af55646fe51effe9592cb26/build/parseSpec.c#L813)!

Also, note that the above referenced Fedora documentation describing spec file comments goes on to mention "inline comments"--so somebody was thinking about comments that didn't start at the beginning of a line.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/829#issuecomment-528956053
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190906/1cf1c6c0/attachment.html>


More information about the Rpm-maint mailing list