[Rpm-maint] [rpm-software-management/rpm] Cannot leave comments after %endif (#829)

Panu Matilainen notifications at github.com
Mon Sep 9 09:21:46 UTC 2019

Rpm has only ever supported comments at the beginning of a spec line, ie *lines starting with #*, but like @ernestask points out, much of the spec is actually shell-script where comments are allowed anywhere in the line so it's easy to get mixed up with expectations.

Anything else appearing to work as a comment has been accidental, as in: bugs in the spec parser, 
see the discussion in #625 for a freak show of side-effects that this particular bug has allowed. Also note that what was added is just a warning, if a build is failing it's failing for some other reason.

Eliminating such quirks is in everybody's best interest, but I agree in this case it outlaws a useful pattern. The constructive solution to the problem would be supporting spec #-comments at arbitrary positions, just like the shell does.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190909/a0950761/attachment.html>

More information about the Rpm-maint mailing list