[Rpm-maint] [rpm-software-management/rpm] Rip the marker support for multiline %{expr:...} error messages (#828)

Panu Matilainen notifications at github.com
Mon Sep 9 11:48:49 UTC 2019

pmatilai commented on this pull request.

> @@ -110,6 +110,12 @@ typedef struct _parseState {
 static void exprErr(const struct _parseState *state, const char *msg,
 		    const char *p)
+    const char *s = state->str;
+    s = strchr(s,'\n');

Waste of perfectly good screen estate... Why not just 
```const char *s = strchr(state->str, '\n');```

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190909/c9795bd8/attachment.html>

More information about the Rpm-maint mailing list