[Rpm-maint] [rpm-software-management/rpm] Remove TOK_IDENTIFIER support from expression parsing (#840)

Michael Schroeder notifications at github.com
Tue Sep 17 12:50:42 UTC 2019


Identifier expansion got broken in 2000 when getMacroBody() was
removed from the API (commit ad99fcba52fcc5e8ab636d2f1760c945cdfbf19).

Nobody seemed to have noticied, so it's safe to say that there is
no one that used it the intented way.

With the bad commit there is an unintended use for it: it is
a way to specify a string without the otherwise needed quotes.

So this commit might break some existing spec files, but cleaning
those up is easy and makes the world a better place.
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/840

-- Commit Summary --

  * Remove TOK_IDENTIFIER support from expression parsing

-- File Changes --

    M rpmio/expression.c (54)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/840.patch
https://github.com/rpm-software-management/rpm/pull/840.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/840
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190917/919547ab/attachment.html>


More information about the Rpm-maint mailing list