[Rpm-maint] [rpm-software-management/rpm] Remove TOK_IDENTIFIER support from expression parsing (#840)

Michael Schroeder notifications at github.com
Tue Sep 17 15:42:54 UTC 2019


The problem is that many people do not know that `%var != string` is not valid syntax. Even Panu used `a!=b` in the test suite. I prefer ripping out the code because the currently only `[a-zA-Z][a-zA-Z0-9]*` is supported (it's supposed to match an identifier, but note the missing `_`) and thus it will confuse people.

If we decide to keep the functionality for backwards compatibility, I'll do a different patch that also removes TOK_IDENTIFIER but instead directly generates TOK_STRING without calling rpmExpand().

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/840#issuecomment-532279131
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190917/dc203d57/attachment.html>


More information about the Rpm-maint mailing list