[Rpm-maint] [rpm-software-management/rpm] Stop expanding strings in the expression parser (#845)

Michael Schroeder notifications at github.com
Wed Sep 18 10:49:06 UTC 2019


The %if lines in the specfile are expanded before the expressions
get evaluated, so the re-expansion of strings is surprising.
It's also not done for integers, which makes it inconsistent.

The original expression parser seems to have been written
without taking the upfront expansion into account, thus the
string expansion and the TOK_IDENTIFIER code.

As I can't imagine anybody using this feature lets just drop it.
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/845

-- Commit Summary --

  * Stop expanding strings in the expression parser

-- File Changes --

    M rpmio/expression.c (3)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/845.patch
https://github.com/rpm-software-management/rpm/pull/845.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/845
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190918/c2d5dc0f/attachment.html>


More information about the Rpm-maint mailing list