[Rpm-maint] [rpm-software-management/rpm] Trap division by zero in expression parser (#844)

Michael Schroeder notifications at github.com
Wed Sep 18 10:50:37 UTC 2019


mlschroe commented on this pull request.



> @@ -438,6 +438,10 @@ static Value doMultiplyDivide(ParseState state)
     if (valueIsInteger(v1)) {
       int i1 = v1->data.i, i2 = v2->data.i;
 
+      if ((i2 == 0) && (TOK_DIVIDE)) {

Is `(TOK_DIVIDE)` supposed to be `(op == TOK_DIVIDE)`?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/844#pullrequestreview-289829667
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190918/a7c4cbda/attachment-0001.html>


More information about the Rpm-maint mailing list