[Rpm-maint] [rpm-software-management/rpm] Logical op improvements (#855)

Panu Matilainen notifications at github.com
Tue Sep 24 10:07:54 UTC 2019


Makes the code nicer while enhancing it, what's not to like.

One thing I forgot to mention in some of the earlier patches is that I certainly don't see any need to add those empty comments above functions as the common style in that function is. It's not a showstopper by any means but I'd basically rather see them all eliminated than more added, as we've done elsewhere (and ditto with the ```@param state         expression parser state``` kind of wholly redundant "API docs", its pretty damn obvious what it is...)

I'm fine with merging this as-is though, unless you planning on pushing more commits here?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/855#issuecomment-534489577
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190924/dbd4af14/attachment.html>


More information about the Rpm-maint mailing list