[Rpm-maint] [rpm-software-management/rpm] rpm-4.15.0/plugins/selinux.c:146:8: style: Suspicious condition (#872)

dcb314 notifications at github.com
Sun Sep 29 07:15:30 UTC 2019


rpm-4.15.0/plugins/selinux.c:146:8: style: Suspicious condition (assignment + comparison); Clarify expression with parentheses. [clarifyCondition]

Source code is

   if ((xx = setexecfilecon(path, "rpm_script_t") == 0))

Maybe better code:

   if ((xx = setexecfilecon(path, "rpm_script_t")) == 0)


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/872
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190929/9e9d535b/attachment.html>


More information about the Rpm-maint mailing list