[Rpm-maint] [rpm-software-management/rpm] Discussion: spec tag order and side-effects (#1161)

[nim-nim]

@pmatilai I can not leave the specs “alone”. There are lots of packagers involved. I can not forbid them to set sourcedir, and I can not forbid them to add patches to their spec files, using %{name} as is the Fedora best practice, which breaks instantaneously (as evidenced by the dejavu case).

When that happens they will all get back to the guidelines author (me) and ask for fixing the guidelines, because that is not their responsibility to adapt guidelines that break in the field. In fact there are already been several breakage reports in the past year (in Fedora CI, and other systems) that I had not understood yet because the jenkins Fedora CI logs suck and what was broken when things had already built fine for thousands of times and no backwards compatibility breakage had been announced was unclear.

As for making Name: declaration a manual hack. What kind of advice is that? Do you really have no clue how widely %{name} is used and expected to be used in Source and Patches? The change make this decades-old common pattern radioactive and dangerous to use.

But, if you want to go this way, at least do it cleanly. Make it an official rpm variable (for example %{source_name} and set Name to %{source_name} automatically at %{prep} time in rpm

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1161#issuecomment-611399214
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20200409/a65d1dfc/attachment.html>