[Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: Improved python version and operator handling. (#1015)

torsava notifications at github.com
Thu Apr 9 16:12:33 UTC 2020


> This change incorporates code from https://github.com/gordonmessmer/pyreq2rpm/ which has a test suite of its own.

That's exactly where I took my test data. I have tested your PR and 84 out of 86 tests passed! These are the only 2 issues:

1. Input: foobar4~=2.0
    Expected output: (python3.7dist(foobar4) >= 2 with python3.7dist(foobar4) < 3)
    Actual output: Invalid requirement: python3.7dist(foobar4) ~= 2
                         [crashes pythondistdeps]

2. Input: foobar1~=2.4.8.0
    Expected output: (python3.7dist(foobar1) >= 2.4.8 with python3.7dist(foobar1) < 2.4.9)
    Actual output: (python3.7dist(foobar1) >= 2.4.8 with python3.7dist(foobar1) < 2.5)

However, you did not introduce these issues, the improper handling of a trailing ".0" in some cases was already present in the original version.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1015#issuecomment-611614414
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20200409/de0a07ef/attachment-0001.html>


More information about the Rpm-maint mailing list