[Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: New test suite and various updates and fixes (#1195)

torsava notifications at github.com
Mon Apr 27 10:18:34 UTC 2020


> Any new sources need to be EXTRA_DIST in Makefile.am's. For a moment I was puzzling as to how come this is passing dist-check when the added sources are missing in the release tarball, but then realized the added tests are not getting run in _our_ test-suite. Which to me kinda steps over a certain line.

That is not on purpose, I would love if these tests were also run as part of the upstream test-suite. I thought about hooking it into `make check`. I didn't do it for 2 reasons:

1. These tests require new dependencies, and I wasn't sure if you would want to tie the rpm test suite to the pythondistdeps testing dependencies. This way there's a specific way to run the pythondistdeps test (and perhaps other scripts/ tests later) using `make check-scripts` that can be just added to the CI bot if desired.
 
2. The makefile machinery for `make test` is a bit too confusing to me to easily add to.

However, a separate repo would also work.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1195#issuecomment-619883458
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20200427/356de011/attachment.html>


More information about the Rpm-maint mailing list