[Rpm-maint] [rpm-software-management/rpm] debugedit: Fix missing relocation of .debug_types section. (#1323)

Jan Kratochvil jan.kratochvil at redhat.com
Sat Aug 8 05:04:03 UTC 2020

On Fri, 07 Aug 2020 13:55:35 +0200, Mark Wielaard wrote:
> But I pulled
> that branch and reviewed the actual commits (1d080e02 and c804a960).

git clone -b types git at github.com:jankratochvil/rpm.git rpm-types

commit 8b5bbcc6d586be50b6a251256c39c3b0332b1f2b
    debugedit: Fix missing relocation of .debug_types section.
commit 1d080e02409d181169d3aec2a19192418f253fd3
    [NFC] debugedit: Move code from edit_dwarf2() to edit_info().

> It would be better to have a separate RPM_DEBUGEDIT_TYPES_SETUP that
> does that and leave RPM_DEBUGEDIT_SETUP as is. Otherwise we change the
> existing tests too.

done as: RPM_DEBUGEDIT_SETUP([-fdebug-types-section])

> The only change I would like, as explained above, is to have a separate
> RPM_DEBUGEDIT_TYPES_SETUP. With that it should be good to commit to the
> main branch.


More information about the Rpm-maint mailing list