[Rpm-maint] [rpm-software-management/rpm] Fix changelog trimming to work relative to newest existing entry (#1301) (#1328)

Panu Matilainen notifications at github.com
Mon Aug 10 08:49:01 UTC 2020

%_changelog_trimtime is an absolute timestamp which needs to be constantly
pushed forward to preserve the same relative age, and will start trimming
entries from unchanged packages until none are left, leading to unexpected
and confusing behavior (#1722806, ...)

It's better to trim by age relative to newest changelog entry. This way the
number of trimmed entries will not change unless the spec changes, and at
least one entry is always preserved. Introduce a new %_changelog_trimage
macro for this and mark the broken by design %_changelog_trimtime as
deprecated, but autoconvert an existing trimtime into relative for now.

As a seemingly unrelated change, move the "time" variable declaration
to a narrower scope to unmask the time() function for use on entry.

Fixes: #1301
You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * Fix changelog trimming to work relative to newest existing entry (#1301)

-- File Changes --

    M build/parseChangelog.c (16)
    M macros.in (6)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20200810/f863c471/attachment.html>

More information about the Rpm-maint mailing list