[Rpm-maint] [rpm-software-management/rpm] rpmbuild: Fix `-ts` srpm specfile name (#1397)

Panu Matilainen notifications at github.com
Wed Dec 2 09:51:50 UTC 2020


@pmatilai commented on this pull request.



>      FD_t fd = NULL;
     static const char *tryspec[] = { "Specfile", "\\*.spec", NULL };
 
-    if (!(fd = rpmMkTempFile(NULL, &specFile)))
+    specDir = rpmGetPath("%{_tmppath}", NULL);
+    if (!(fd = rpmMkTempFile(NULL, &tmpSpecFile)))

Hmm, using %_tmpdir brings on yet another problem: rename() will then fail "randomly" depending on your partitioning scheme and commonly fail because of it, which is also not okay. For such a silly little thing this is annoyingly complicated and subtle...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1397#discussion_r534032918
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20201202/2e6ea6f3/attachment.html>


More information about the Rpm-maint mailing list