[Rpm-maint] [rpm-software-management/rpm] Fix 4.16.0 regression causing invalid spec file name on rpmbuild -ts (#1453)

Panu Matilainen notifications at github.com
Wed Dec 2 11:06:56 UTC 2020


Commit acf5e00281d73a2f8034091241c7b0e2ba00e383 cut a couple of corners
too many, causing the temporary file name used to extract the spec from
the tarball to end up in the src.rpm too.

Revert back to creating %_specdir for tar builds, it might not be
optimal but it's not exactly harmful either (%_sourcedir is different).
The "truly correct" solutions get increasingly complicated for such
a silly thing as this is. In addition to creating the %_specdir, we
also need to rename the file to its proper name, simplify that code
a bit while at it and add a test-case.

Fixes: #1386
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/1453

-- Commit Summary --

  * Fix 4.16.0 regression causing invalid spec file name on rpmbuild -ts

-- File Changes --

    M rpmbuild.c (22)
    M tests/rpmbuild.at (15)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/1453.patch
https://github.com/rpm-software-management/rpm/pull/1453.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1453
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20201202/49182825/attachment.html>


More information about the Rpm-maint mailing list