[Rpm-maint] [rpm-software-management/rpm] Allow database probing if _db_backend is not set (#1451)

Neal Gompa (ニール・ゴンパ) notifications at github.com
Wed Dec 2 13:28:38 UTC 2020


@Conan-Kudo requested changes on this pull request.



> @@ -97,7 +98,7 @@ dbDetectBackend(rpmdb rdb)
 		rpmlog(RPMLOG_WARNING,
 			_("Converting database from %s to %s backend\n"),
 			ondisk->name, cfg->name);
-	    } else {
+	    } else if (*db_backend) {

Does it make sense here to have no final `else` case? This seems not right...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1451#pullrequestreview-542832541
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20201202/3909f438/attachment.html>


More information about the Rpm-maint mailing list