[Rpm-maint] [rpm-software-management/rpm] platform: Ensure empty buildroot for %install (#1039)

Panu Matilainen notifications at github.com
Mon Feb 3 10:04:53 UTC 2020

Yeah, this *functionality* really should be in rpm, should've been ages ago. The thing is, I was about to basically add the patch originating from Suse (later adopted by Fedora etc) multiple times but there was ... something. Something with the details that I don't really remember, but then some of those details will have changed in the meantime. I think the original patch was against rpm 4.4 which is reaaaaaaally old and different...

As of this particular adaptation, a couple of things that immediately come to mind:
- no need to shell out to use `dirname`, just use the "%{dirname:...}" built-in macro
- since rpm >= 4.6, %{buildroot} is guaranteed to be defined to non-empty, non-"/" value so the tests are fairly redundant

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20200203/c0e23292/attachment-0001.html>

More information about the Rpm-maint mailing list