[Rpm-maint] [rpm-software-management/rpm] Fix isUnorderedReq() for multiple qualifiers (#1031)

Panu Matilainen notifications at github.com
Mon Feb 3 10:29:48 UTC 2020


pmatilai commented on this pull request.



> @@ -82,12 +82,16 @@ typedef rpmFlags rpmsenseFlags;
     _notpre(RPMSENSE_SCRIPT_PREUN|RPMSENSE_SCRIPT_POSTUN)
 #define _UNORDERED_ONLY_MASK \
     _notpre(RPMSENSE_RPMLIB|RPMSENSE_CONFIG|RPMSENSE_PRETRANS|RPMSENSE_POSTTRANS|RPMSENSE_SCRIPT_VERIFY)
+#define _STILL_ORDERED_MASK \
+    _notpre(RPMSENSE_SCRIPT_PRE|RPMSENSE_SCRIPT_POST|RPMSENSE_SCRIPT_PREUN|RPMSENSE_SCRIPT_POSTUN)

Although okay, calling it that might also be misleading since it'll miss the case where no flags at all have been set.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1031#discussion_r374026094
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20200203/4caead30/attachment.html>


More information about the Rpm-maint mailing list