[Rpm-maint] [rpm-software-management/rpm] Make "%patchlist -f patches" work. v2 (#1043)

Panu Matilainen notifications at github.com
Tue Feb 4 09:04:27 UTC 2020


pmatilai commented on this pull request.



> @@ -2244,6 +2245,12 @@ int readManifest(rpmSpec spec, const char *path, const char *descr, int flags,
 	    continue;
 	if (specExpand(spec, lineno, buf, &expanded))
 	    goto exit;
+	if (flags & STRIP_TRAILINGSPACE) {
+	    char *end = expanded + strlen(expanded) - 1;
+	    while (end >= expanded && isspace((unsigned char)*end))

Use risspace() instead, it'll also save you from having to include ctype.h

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1043#pullrequestreview-352813337
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20200204/29238efb/attachment.html>


More information about the Rpm-maint mailing list