[Rpm-maint] [rpm-software-management/rpm] Make "%patchlist -f patches" work. v2 (#1043)

Panu Matilainen notifications at github.com
Tue Feb 4 09:06:26 UTC 2020


pmatilai commented on this pull request.



> @@ -8,13 +8,99 @@
 #include "build/rpmbuild_internal.h"
 #include "debug.h"
 
+static int addLinesFromFile(rpmSpec spec, const char * const fn, rpmTagVal tag)
+{
+    int nlines = 0;
+    int flags = STRIP_COMMENTS | STRIP_TRAILINGSPACE;
+    ARGV_t argv = NULL;
+
+    int terminate = rpmExpandNumeric(tag == RPMTAG_SOURCE
+				     ? "%{?_empty_sourcelist_terminate_build}"
+				     : "%{?_empyy_patchlist_terminate_build}");

The patchlist macro has a typo (empyy vs empty). However the bigger thing is that I don't think these should be configurable. With %files, an empty %files section is special as that controls whether the package gets built at all, but for source and patch lists, I don't see any reason to allow them to be empty. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1043#pullrequestreview-352814509
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20200204/9f458898/attachment.html>


More information about the Rpm-maint mailing list