[Rpm-maint] [rpm-software-management/rpm] platform: Ensure empty buildroot for %install (#1039)

Panu Matilainen notifications at github.com
Tue Feb 4 14:23:58 UTC 2020


Okay, but now we're using data from two different sources: %{buildroot} macro and $RPM_BUILD_ROOT environment variable. So it looks inconsistent, but also might *be* inconsistent: they are defined and evaluated in different points in time, and ... although it shouldn't, stuff can happen in the interim.
 
I also still dislike the buildroot conditional. If A adds them just in case because B also adds them just in case then C, D and E will also keep adding that cruft ad infinitum. That is not a reason at all.
The fact that Fedora and derivatives have done without such a conditional for over 10 years is a pretty strong testimony that it *really* is not needed. The "/" check is similarly hysterical, because adding such conditionals makes people think they can actually happen. Witness this discussion.

I *would* accept a patch that turns all the buildroot checking into an assert type of thing that just fails the build immediately: we *know* rpm is supposed to set a sane buildroot, and if it isn't then something is very wrong and we shouldn't continue at all.




-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1039#issuecomment-581933061
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20200204/fb57d43d/attachment-0001.html>


More information about the Rpm-maint mailing list